nilotpalnandi commented on a change in pull request #283: HDDS-2651 Make
startId parameter non-mandatory while listing containe…
URL: https://github.com/apache/hadoop-ozone/pull/283#discussion_r355345894
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##########
@@ -217,7 +217,7 @@ public ContainerInfo getContainer(final ContainerID
containerID)
Collections.sort(containersIds);
return containersIds.stream()
- .filter(id -> id.getId() > startId)
+ .filter(id -> id.getId() >= startId)
Review comment:
If the user specifies startID =1 , it lists containers starting from
container id#2. (not container id#1)
I think it would be good if the startID is kept intact and make the
iteration of container inclusive of startID for better user experience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
