timmylicheng commented on a change in pull request #291: HDDS-1574 Average out
pipeline allocation on datanodes and add metrcs/test
URL: https://github.com/apache/hadoop-ozone/pull/291#discussion_r355834682
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -143,11 +156,19 @@ private void initializePipelineState() throws
IOException {
Pipeline pipeline = Pipeline.getFromProtobuf(pipelineBuilder.setState(
HddsProtos.PipelineState.PIPELINE_ALLOCATED).build());
Preconditions.checkNotNull(pipeline);
+ pipeline.setNodeIdsHash(computeNodeIdHash(pipeline));
stateManager.addPipeline(pipeline);
nodeManager.addPipeline(pipeline);
}
}
+ private boolean checkPipelineContainSameDatanodes(Pipeline pipeline) {
+ List<Pipeline> pipelines = stateManager.getPipelines(ReplicationType.RATIS,
+ ReplicationFactor.THREE, Pipeline.PipelineState.OPEN);
+ return (int)pipelines.stream().filter(p -> p.getNodeIdsHash()
+ == pipeline.getNodeIdsHash()).count() > 0;
+ }
Review comment:
Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
