xiaoyuyao commented on a change in pull request #291: HDDS-1574 Average out pipeline allocation on datanodes and add metrcs/test URL: https://github.com/apache/hadoop-ozone/pull/291#discussion_r356244699
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineUtils.java ########## @@ -100,4 +105,45 @@ static void destroyPipeline(DatanodeDetails dn, PipelineID pipelineID, true, p.getId()); } } + + static int encodeNodeIdsOfFactorThreePipeline(List<DatanodeDetails> nodes) { + if (nodes.size() != HddsProtos.ReplicationFactor.THREE.getNumber()) { + return 0; + } + List<UUID> nodeIds = nodes.stream() + .map(DatanodeDetails::getUuid).distinct() + .collect(Collectors.toList()); + nodeIds.sort(new ComparableComparator()); + // Only for Factor THREE pipeline. + return new HashCodeBuilder() + .append(nodeIds.get(0).toString()) + .append(nodeIds.get(1).toString()) + .append(nodeIds.get(2).toString()) + .toHashCode(); + } + + /** + * Return first existed pipeline which share the same set of datanodes + * with the input pipeline. + * @param stateManager PipelineStateManager + * @param pipeline input pipeline + * @return first matched pipeline + */ + static Pipeline checkPipelineContainSameDatanodes( + PipelineStateManager stateManager, Pipeline pipeline) { + List<Pipeline> matchedPipelines = stateManager.getPipelines( + HddsProtos.ReplicationType.RATIS, + HddsProtos.ReplicationFactor.THREE) + .stream().filter(p -> !p.equals(pipeline) && Review comment: Need to check the override of equals() in Pipeline object, the list of nodes may not in the same order. This requires us to use getNodesInOrder instead of getNodes(). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org