xiaoyuyao commented on a change in pull request #164: HDDS-426. Add field
modificationTime for Volume and Bucket
URL: https://github.com/apache/hadoop-ozone/pull/164#discussion_r358289258
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java
##########
@@ -132,6 +135,10 @@ public void setCreationTime(long time) {
this.creationTime = time;
}
+ public void updateModificationTime() {
+ this.modificationTime = System.currentTimeMillis();
Review comment:
NIT: Should we use Time.now() which is a wrapper of System.currentTimeMillis
consistently across the patch? This will make it easier to maintain the code in
the long run. Otherwise, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
