swagle commented on a change in pull request #353: HDDS-2623. Expose
SCMDatanodeProtocolServer RPC endpoint through Recon.
URL: https://github.com/apache/hadoop-ozone/pull/353#discussion_r358407725
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
##########
@@ -77,10 +78,9 @@ protected void configureServlets() {
LOG.info("Starting Recon server");
httpServer.start();
- //Start Ozone Manager Service that pulls data from OM.
- OzoneManagerServiceProvider ozoneManagerServiceProvider = injector
- .getInstance(OzoneManagerServiceProvider.class);
- ozoneManagerServiceProvider.start();
+ getOzoneManagerServiceProvider().start();
Review comment:
Service providers generally should not have a life cycle method. Let's start
a service provided by the OzoneManagerServiceProvider, or refactor to an inner
class of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
