sodonnel commented on a change in pull request #343: HDDS-2607 DeadNodeHandler
should not remove replica for a dead maintenance node
URL: https://github.com/apache/hadoop-ozone/pull/343#discussion_r358857130
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DeadNodeHandler.java
##########
@@ -74,12 +74,14 @@ public void onMessage(final DatanodeDetails
datanodeDetails,
* To be on a safer side, we double check here and take appropriate
* action.
*/
-
destroyPipelines(datanodeDetails);
closeContainers(datanodeDetails, publisher);
- // Remove the container replicas associated with the dead node.
- removeContainerReplicas(datanodeDetails);
+ // Remove the container replicas associated with the dead node unless it
+ // is IN_MAINTENANCE
+ if (!nodeManager.getNodeStatus(datanodeDetails).isInMaintenance()) {
Review comment:
If a node goes dead while "entering maintenance" then it should be handled
as a dead node. The reason, is that we have not yet determine if all the
containers on the host are sufficiently replicated. If it goes dead before that
check has completed and the node has moved into IN_MAINTENANCE, then it must be
handled as a dead node as normal.
This is the same for a node which is DECOMMISSIONING and not yet reached
DECOMMISSIONED.
Unless the node has reached its end state (IN_MAINTENANCE or
DECOMMISSIONED), if it goes dead the workflow is aborted and it is handled just
like any other dead node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
