hanishakoneru commented on a change in pull request #369: HDDS-2755. Compare
transactionID and updateID of Volume operations to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/369#discussion_r359017562
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/OMClientResponse.java
##########
@@ -40,6 +41,21 @@ public OMClientResponse(OMResponse omResponse) {
this.omResponse = omResponse;
}
+ /**
+ * Check if omResponse status is OK. If yes, add to DB.
+ * For OmResponse with failure, this should do nothing. This method is not
+ * called in failure scenario in OM code.
+ * @param omMetadataManager
+ * @param batchOperation
+ * @throws IOException
+ */
+ public void checkAndUpdateDB(OMMetadataManager omMetadataManager,
Review comment:
Yes. I will handle this when I get to Multipart idempotence. I noticed that
in some requests, we missed checking status OK. So thought we should have it in
the abstract class itself as it is common code also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
