bharatviswa504 commented on a change in pull request #369: HDDS-2755. Compare
transactionID and updateID of Volume operations to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/369#discussion_r359019859
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/OMClientResponse.java
##########
@@ -40,6 +41,21 @@ public OMClientResponse(OMResponse omResponse) {
this.omResponse = omResponse;
}
+ /**
+ * Check if omResponse status is OK. If yes, add to DB.
+ * For OmResponse with failure, this should do nothing. This method is not
+ * called in failure scenario in OM code.
+ * @param omMetadataManager
+ * @param batchOperation
+ * @throws IOException
+ */
+ public void checkAndUpdateDB(OMMetadataManager omMetadataManager,
Review comment:
But until we fix Multipart Idempotence, when this is merged, for multipart
requests we behave wrongly correct?. As now in OzoneManagerDoubleBuffer, we
call addToDBBatch only when the status is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
