bharatviswa504 commented on a change in pull request #381: Hdds 2781. Add
ObjectID and updateID to BucketInfo to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/381#discussion_r360512195
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
##########
@@ -212,6 +266,8 @@ public static Builder newBuilder() {
auditMap.put(OzoneConsts.STORAGE_TYPE,
(this.storageType != null) ? this.storageType.name() : null);
auditMap.put(OzoneConsts.CREATION_TIME, String.valueOf(this.creationTime));
+ auditMap.put(OzoneConsts.OBJECT_ID, String.valueOf(this.getObjectID()));
Review comment:
Yaa agreed, but recently in one of PR a discussion came up that audit log is
for to find information who did what operation, but not for debugging. So, if
needed during debugging, we can log this information during performing the
actual operation.
Having precise/required information in audit logs will help when flushing
audit logs and also the size of the audit log. So, I feel having this
information is not really required. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
