nandakumar131 commented on a change in pull request #385: HDDS-2779. Fix list 
volume for --start parameter
URL: https://github.com/apache/hadoop-ozone/pull/385#discussion_r360691022
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
 ##########
 @@ -815,34 +815,55 @@ public boolean isBucketEmpty(String volume, String 
bucket)
     }
     volumes = getVolumesByUser(userName);
 
-    if (volumes == null || volumes.getVolumeNamesCount() == 0) {
+    if (volumes.getVolumeNamesCount() == 0) {
       return result;
     }
 
+    /* Process listing volumes with startVolume. */
     boolean startKeyFound = Strings.isNullOrEmpty(startKey);
+    if (!startKeyFound) {
+      OmVolumeArgs startVolArgs = getVolumeTable()
 
 Review comment:
   This will break the case where the user provides "/" at the start of volume 
name, we should also handle that case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to