bharatviswa504 commented on issue #399: HDDS-2424. Add the recover-trash command server side handling. URL: https://github.com/apache/hadoop-ozone/pull/399#issuecomment-571345754 Recover trash is a write request command as this moves the keys from the delete table to the original key table. let me know if I am missing something here. 2 comments. 1. In code it is marked as read-only, should it be write request in OM? 2. If write request should follow the implementation of write requests (preExecute/ValidateAndUpdatecache) As for write request commands, we should follow HA kind of request implementation. For reference this design link [write link](https://issues.apache.org/jira/secure/attachment/12973260/Handling%20Write%20Requests%20with%20OM%20HA.pdf)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
