bharatviswa504 commented on a change in pull request #428: HDDS-2868. Add ObjectID and UpdateID to OMKeyInfo. URL: https://github.com/apache/hadoop-ozone/pull/428#discussion_r365092199
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ########## @@ -416,12 +419,14 @@ protected OmKeyInfo prepareKeyInfo( @Nonnull KeyArgs keyArgs, @Nonnull String dbKeyName, long size, @Nonnull List<OmKeyLocationInfo> locations, @Nullable FileEncryptionInfo encInfo, - @Nonnull PrefixManager prefixManager, @Nullable OmBucketInfo omBucketInfo) + @Nonnull PrefixManager prefixManager, + @Nullable OmBucketInfo omBucketInfo, + @Nonnull long transactionLogIndex) Review comment: NIT: primitive type, we dont need @nonNull ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org