swagle commented on a change in pull request #466: HDDS-2869. Handle pipeline bootstrap from SCM and create pipeline use case in Recon. URL: https://github.com/apache/hadoop-ozone/pull/466#discussion_r371546781
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java ########## @@ -200,6 +210,16 @@ public Pipeline getPipeline(PipelineID pipelineID) } } + @Override + public boolean containsPipeline(PipelineID pipelineID) { Review comment: Instead of contains, we could have made the get return an Optiona<Pipeline> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org