swagle commented on a change in pull request #503: HDDS-2850. Handle Create container use case in Recon. URL: https://github.com/apache/hadoop-ozone/pull/503#discussion_r372723418
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java ########## @@ -194,6 +194,18 @@ public ContainerInfo getContainer(final ContainerID containerID) return containerStateManager.getContainer(containerID); } + @Override + public boolean exists(ContainerID containerID) { + lock.lock(); Review comment: This should likely be filed as separate Jira, but why is this not a ReadWriteLock? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org