hanishakoneru commented on a change in pull request #505: HDDS-2956. Handle
Replay of AllocateBlock request
URL: https://github.com/apache/hadoop-ozone/pull/505#discussion_r373605058
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -134,8 +135,7 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
@Override
public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
- long transactionLogIndex,
- OzoneManagerDoubleBufferHelper ozoneManagerDoubleBufferHelper) {
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
Review comment:
Sure. I will avoid it in future. The variable names were so big that it was
causing unnecessary increase in the lines of code. I was trying to club code
cleanup along with these changes. But I will reserve it for separate Jira in
the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
