hanishakoneru commented on a change in pull request #498: HDDS-2940. mkdir : create key table entries for intermediate directories in the path URL: https://github.com/apache/hadoop-ozone/pull/498#discussion_r374873271
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/file/OMDirectoryCreateResponse.java ########## @@ -39,11 +40,17 @@ public static final Logger LOG = LoggerFactory.getLogger(OMDirectoryCreateResponse.class); private OmKeyInfo dirKeyInfo; + private List<OmKeyInfo> parentKeyInfos; + private boolean createPrefix; public OMDirectoryCreateResponse(@Nullable OmKeyInfo dirKeyInfo, - @Nonnull OMResponse omResponse) { + @Nullable List<OmKeyInfo> parentKeyInfos, + @Nonnull OMResponse omResponse, + boolean createPrefix) { Review comment: We can avoid passing the createPrefix param and use parentKeyInfos != null check only instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org