bharatviswa504 commented on issue #536: HDDS-2988. Use getPropertiesByPrefix instead of regex in matching ratis client and server properties. URL: https://github.com/apache/hadoop-ozone/pull/536#issuecomment-584223834 > Thanks the patch @bharatviswa504 > > Overall I like the idea to use string manipulation instead of regexp but it's a little hard to read the structure of the configuration. Maybe because the duplication of the "server/grpc" words in `datanode.ratis.grpc.raft.grpc.flow.control` (As I asked in an other comment why do we need the first grpc?). The reason for server, client and grpc prefix is to group the configurations by the group. So, that it will be easy to add these configurations in different classes(like have a class for Ratis Server, One for Ratis Client ..) instead of just having all the configuration in a single class.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
