bharatviswa504 commented on a change in pull request #627: HDDS-3118. Possible deadlock in LockManager. URL: https://github.com/apache/hadoop-ozone/pull/627#discussion_r387457357
########## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/lock/LockManager.java ########## @@ -57,12 +56,9 @@ public LockManager(final Configuration conf) { * @param fair - true to use fair lock ordering, else non-fair lock ordering. */ public LockManager(final Configuration conf, boolean fair) { - final int maxPoolSize = conf.getInt( - HddsConfigKeys.HDDS_LOCK_MAX_CONCURRENCY, - HddsConfigKeys.HDDS_LOCK_MAX_CONCURRENCY_DEFAULT); lockPool = new GenericObjectPool<>(new PooledLockFactory(fair)); - lockPool.setMaxTotal(maxPoolSize); + lockPool.setMaxTotal(-1); Review comment: yes, I did this expicitly, if in future releases if they changed the defaults it might break when we upgrade the commons-pool2. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org