sodonnel commented on a change in pull request #678: HDDS-3179 Pipeline
placement based on Topology does not have fallback
URL: https://github.com/apache/hadoop-ozone/pull/678#discussion_r393661301
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
##########
@@ -99,9 +99,11 @@ boolean meetCriteria(DatanodeDetails datanodeDetails, int
nodesRequired) {
try {
pipeline = stateManager.getPipeline(pid);
} catch (PipelineNotFoundException e) {
- LOG.error("Pipeline not found in pipeline state manager during" +
- " pipeline creation. PipelineID: " + pid +
- " exception: " + e.getMessage());
+ if (LOG.isDebugEnabled()) {
Review comment:
The other logs have been changed, but this one is still using interpolation
and is wrapped in the if statement. Could you change it too please?
With SLF4J, if you pass an exception object as the last parameter it will
print the full stack into the log automatically, eg:
```
LOG.debug("Pipeline not found in pipeline state manager during" +
" pipeline creation. PipelineID: {}", pid, e);
```
I don't think the full stack will get printed using string concatenation as
that will call toString on the exception which will just return the message
part and not the stack trace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
