bharatviswa504 edited a comment on issue #690: HDDS-3221. Refactor SafeModeHandler to use a Notification Interface URL: https://github.com/apache/hadoop-ozone/pull/690#issuecomment-600851742 > Thanks @sodonnel for working on this. > > I feel that instead of maintaining safemode state at different places, it should be maintained in one single place and that value should be accessed where ever required. > > Safemode state change event handler should only worry about starting the services that are required to be started while coming out of safemode. > > I agree that the existing code doesn't reflect this, I have always wanted to make this change. For cases like clientProtocolServer, blockManager we have a check in safemode and not allow few operations inside those classes. So, these cannot be handled by safemodehandler. Otherwise I need to pass safemodehandler object to those classes. I am talking about the current code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
