bharatviswa504 commented on a change in pull request #625: HDDS-2980. Delete replayed entry from OpenKeyTable during commit URL: https://github.com/apache/hadoop-ozone/pull/625#discussion_r396189604
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java ########## @@ -183,21 +196,26 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, new CacheKey<>(dbOzoneKey), new CacheValue<>(Optional.of(omKeyInfo), trxnLogIndex)); - omResponse.setCommitKeyResponse(CommitKeyResponse.newBuilder().build()); omClientResponse = new OMKeyCommitResponse(omResponse.build(), - omKeyInfo, commitKeyRequest.getClientID()); + omKeyInfo, dbOpenKey); Review comment: We can still pass here clientID and generate openKey. Like how we used to generate open key before. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org