adoroszlai commented on a change in pull request #701: HDDS-2691. Ozone Shell
code cleanup
URL: https://github.com/apache/hadoop-ozone/pull/701#discussion_r397115302
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/Handler.java
##########
@@ -54,4 +58,55 @@ public OzoneConfiguration createOzoneConfiguration() {
return parent.createOzoneConfiguration();
}
+ protected abstract OzoneAddress getAddress() throws OzoneClientException;
+
+ protected abstract void execute(OzoneClient client, OzoneAddress address)
+ throws IOException, OzoneClientException;
+
+ @Override
+ public Void call() throws Exception {
+ conf = createOzoneConfiguration();
+
+ OzoneAddress address = getAddress();
+ try (OzoneClient client = createClient(address)) {
+ if (isVerbose()) {
+ address.print(out());
+ }
Review comment:
`createClient()` is overridden in `S3Handler`, so that would introduce some
duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
