fapifta commented on a change in pull request #704: HDDS-3248. shutdown
defaultMetricsSystem before tests
URL: https://github.com/apache/hadoop-ozone/pull/704#discussion_r397231320
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestHddsDispatcher.java
##########
@@ -276,6 +283,13 @@ private HddsDispatcher createDispatcher(DatanodeDetails
dd, UUID scmId,
return hddsDispatcher;
}
+ private void shutdownDispatcher(HddsDispatcher dispatcher){
+ if(dispatcher != null) {
+ dispatcher.shutdown();
+ }
+ ContainerMetrics.remove();
Review comment:
I am not convinced whether this step to remove the ContainerMetrics belongs
to a method called shutdownDispatcher, at least from the name it is not clear
it will do so besides shutting down the dispatcher. Shouldn't we separate this
two?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
