swagle commented on a change in pull request #718: HDDS-3224. Enforce volume
and bucket name rule at create time.
URL: https://github.com/apache/hadoop-ozone/pull/718#discussion_r397613365
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1894,10 +1896,12 @@ private void checkAdmin() throws OMException {
@Override
public void createBucket(OmBucketInfo bucketInfo) throws IOException {
try {
- if(isAclEnabled) {
+ if (isAclEnabled) {
checkAcls(ResourceType.VOLUME, StoreType.OZONE, ACLType.CREATE,
bucketInfo.getVolumeName(), bucketInfo.getBucketName(), null);
}
+ HddsClientUtils.verifyResourceName(bucketInfo.getVolumeName(),
Review comment:
Added the checks at suggested sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
