elek commented on a change in pull request #710: HDDS-3173. Provide better
default JVM options
URL: https://github.com/apache/hadoop-ozone/pull/710#discussion_r397785874
##########
File path: hadoop-ozone/dist/src/shell/hdds/hadoop-functions.sh
##########
@@ -1541,6 +1541,21 @@ function hadoop_translate_cygwin_path
fi
}
+## @description Adds default GC parameters
+## @description Only for server components and only if no other -XX parameters
+## @description are set
+## @audience private
+## @stability evolving
+## @replaceable yes
+function hadoop_add_default_gc_opts
+{
+ if [[ "${HADOOP_SUBCMD_SUPPORTDAEMONIZATION}" == true ]]; then
+ hadoop_debug "Appending default GC parameter to the HADOOP_OPTS"
+ if [[ ! "$HADOOP_OPTS" =~ "-XX" ]] ; then
+ HADOOP_OPTS="${HADOOP_OPTS} -XX:ParallelGCThreads=8
-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=70
-XX:+CMSParallelRemarkEnabled"
Review comment:
Yes, but as I learned from @arp7 we have no better option, right now. As I
know G1 doesn't provide the same performance (yet).
The idea here was provide some very basic default to avoid bad experience
for the users who use Ozone out-of-the-box. And advanced users can set any
smart default.
Or do you suggest G1 by default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
