sodonnel commented on a change in pull request #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#discussion_r400519566
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java ########## @@ -146,6 +152,16 @@ public void setPipelineProvider(ReplicationType replicationType, pipelineFactory.setProvider(replicationType, provider); } + @VisibleForTesting + public void setAllowPipelineCreation(boolean newState) { + this.allowPipelineCreation.set(newState); + } + + @VisibleForTesting + public boolean getAllowPipelineCreation() { + return allowPipelineCreation.get(); + } + Review comment: I think your naming is better. I will push a new commit for that change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org