rakeshadr commented on a change in pull request #730: HDDS-3289. Add a freon generator to create nested directories. URL: https://github.com/apache/hadoop-ozone/pull/730#discussion_r400640465
########## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopDirGenerator.java ########## @@ -0,0 +1,101 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.freon; + +import java.net.URI; +import java.util.concurrent.Callable; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hdds.cli.HddsVersionProvider; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; + +import org.apache.commons.lang3.RandomStringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; + +/** + * Directory generator tool test om performance. + */ +@Command(name = "ddsg", + aliases = "dfs-directory-generator", + description = + "Create random directories to the any dfs compatible file system.", + versionProvider = HddsVersionProvider.class, + mixinStandardHelpOptions = true, + showDefaultValues = true) +public class HadoopDirGenerator extends BaseFreonGenerator + implements Callable<Void> { + + private static final Logger LOG = + LoggerFactory.getLogger(HadoopDirGenerator.class); + + @Option(names = {"--dpath"}, + description = "Hadoop FS directory system path", + defaultValue = "o3fs://bucket2.vol2") + private String rootPath; + + + @Option(names = {"-d", "--depth"}, + description = "Number of directories to be generated recursively", + defaultValue = "5") + private int depth; + + @Option(names = {"--span"}, + description = + "Number of child directories to be created in leaf directory.", + defaultValue = "10") + private int span; + + @Option(names = {"--nameLen"}, + description = + "Length of the random name of directory you want to create.", + defaultValue = "10") + private int n; + + private FileSystem fileSystem; + + @Override + public Void call() throws Exception { + + init(); + OzoneConfiguration configuration = createOzoneConfiguration(); + fileSystem = FileSystem.get(URI.create(rootPath), configuration); + runTests(this::createDir); + return null; + + } + + private void createDir(long counter) throws Exception { Review comment: can you please add java comment or javadoc describing the nested dir structure that this function creates. For example, ``` /rootdir | |+ level1dir1 |+ level1dir2 | |+ level2dir1 |+ level2dir2 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
