runzhiwang commented on issue #740: HDDS-3307. Improve write efficiency by avoiding reverse DNS lookup URL: https://github.com/apache/hadoop-ozone/pull/740#issuecomment-607011449 > @runzhiwang Thanks for the PR and improvement. > > I have few comments. > > I have one general question, now in native authorizer, the hostname is not used during checkAcls, in the future if we use, allow requests from this host like settings, then with this approach, someone can set the hostName, even though the request is not from that host. This can happen with this code change, I am not sure we will support this kind of scenario or not. Just flagging this here. @bharatviswa504 Thanks for your review. Very reasonable question. And I also doubt whether we need hostName in authorizer, because getHostName() from IP is a block call, maybe block a very long time, it's dangerous. If we do not need hostName in authorizer, we can delete `getHostName `and also no need to `setHostName `in client.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
