elek commented on issue #726: HDDS-3267. replace ContainerCache in BlockUtils by LoadingCache URL: https://github.com/apache/hadoop-ozone/pull/726#issuecomment-610970355 One more comment: In this patch an Apache commons based cache is replaced by a Guava based cache. Guava can be better from technical point of view and it might be a good step, but I have to mention here the unlimited pain from Guava, especially the pain related to the backward compatibility of Guava. Check the "guava shading" thread on Apache Hadoop dev mailing lists. Hadoop uses guava but downstream projects may also use guava but with different version. It's very frequent that there are non-compatible changes between versions. of Guava which makes where hard to use Hadoop (with unshaded guava). Which is understandable because guava development is driven by the needs of Google. And inside Google it's not a big problem due to the usage of one mono-repo. But in external, open source world, a project which has open governance and more strict backward compatible rules, can be better. It doesn't mean that I think Guava never can be used (especially if there are no alternatives). But this is huge, read, blinking warning.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
