rakeshadr commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete and batchRename. URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r407596897
########## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java ########## @@ -748,19 +751,34 @@ public String toString() { */ boolean iterate() throws IOException { LOG.trace("Iterating path {}", path); + List<String> keyList = new ArrayList<>(); if (status.isDirectory()) { LOG.trace("Iterating directory:{}", pathKey); while (keyIterator.hasNext()) { BasicKeyInfo key = keyIterator.next(); LOG.trace("iterating key:{}", key.getName()); - if (!processKey(key.getName())) { + if (!key.getName().equals("")) { + keyList.add(key.getName()); + } + int batchSize = getConf().getInt("ozone.fs.iterate.batch-size", 1); Review comment: Instead of hard coding, can you do `OzoneConfigKeys.OZONE_FS_ITERATE_BATCH_SIZE` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org