timmylicheng commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-613865710 > I think this looks better and I have just a few minor comments. I added a few inline plus these two: > > At line 243: > > ``` > // First choose an anchor nodes randomly > DatanodeDetails anchor = chooseNode(healthyNodes); > ``` > > This no longer picks a random node - it just picks the lowest loaded node. I wonder if this first anchor node should be a random node? > > Method getHigherLoadNodes() does not seem to be used any longer, so we can remove it. > > This code has changed a lot with this patch, and this is really my first time looking at it. It would be great if @ChenSammi could give this a review too, after addressing the minor points I mentioned here? I've addressed these comments. Thanks. I will check if @ChenSammi had bandwidth to do a review.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
