elek commented on a change in pull request #827: HDDS-3397 Make jmh jar
dependencies optional
URL: https://github.com/apache/hadoop-ozone/pull/827#discussion_r409326687
##########
File path: hadoop-ozone/dist/src/shell/ozone/ozone
##########
@@ -130,6 +130,18 @@ function ozonecmd_case
OZONE_RUN_ARTIFACT_NAME="hadoop-ozone-tools"
;;
genesis)
+ ARTIFACT_LIB_DIR="${HADOOP_HDFS_HOME}/share/ozone/lib/hadoop-ozone-tools"
+ mkdir -p "$ARTIFACT_LIB_DIR"
+ if [[ ! -f "$ARTIFACT_LIB_DIR/jmh-core-1.23.jar" ]]; then
+ echo "jmh-core jar is missing from $ARTIFACT_LIB_DIR, trying to
download from maven central (License: GPL + classpath execption)"
+ wget -O "$ARTIFACT_LIB_DIR/jmh-core-1.23.jar"
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.23/jmh-core-1.23.jar
Review comment:
> How do we choose between wget and curl?
`if random.getNextInt() % 2 == 0 --> wget`
;-)
Will replace it with `curl` if that one is your preference. Is it more
common?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
