xiaoyuyao commented on a change in pull request #830: HDDS-3392.OM create key/file should not generate different data encryption key during validateAndUpdateCache. URL: https://github.com/apache/hadoop-ozone/pull/830#discussion_r409733651
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java ########## @@ -213,10 +213,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, OmBucketInfo bucketInfo = omMetadataManager.getBucketTable().get( omMetadataManager.getBucketKey(volumeName, bucketName)); - encryptionInfo = getFileEncryptionInfo(ozoneManager, bucketInfo); omKeyInfo = prepareKeyInfo(omMetadataManager, keyArgs, dbKeyInfo, - keyArgs.getDataSize(), locations, encryptionInfo.orNull(), + keyArgs.getDataSize(), locations, getFileEncryptionInfo(keyArgs), Review comment: NIT: Given we have pass keyArgs, we can reduce the number of arguments here to avoid @SuppressWarnings("parameternumber") for prepareKeyInfo(). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org