maobaolong commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-615009528 @bharatviswa504 Thank you for your review and your reply. There are the reasons why i did this moving. - If I don't build my repo locally, it means that the local source repo lack of the java source files generated by protobuf, for the current approach, many error appear in the classes contains reference of protobuf generated class while you view source in an IDE, whatever intellij idea and Eclipse. - Put the serialized and deserialized logic into the high level class, i think it is harmful for reading high level code logic, actually, some people do not care about how to serialized but care more about the data structure. Now each class have two method for serialized and deserialized purpose, and it is red color by IDE before i successful compile my repo. - I think we can separate the class into two layer, and the serialized and deserialized logic should be in the low-level layer. - In fact, i'm effected by HDFS and Alluxio, so, i'm very happy to discuss with you further more.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
