adoroszlai commented on a change in pull request #834: HDDS-3101. Depend on
lightweight ConfigurationSource interface instead of Hadoop Configuration
URL: https://github.com/apache/hadoop-ozone/pull/834#discussion_r410160058
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/freon/OzoneGetConf.java
##########
@@ -234,7 +236,7 @@ public Integer run() throws Exception {
public int doWorkInternal(OzoneGetConf tool, String[] args)
throws IOException {
Collection<InetSocketAddress> addresses = HddsUtils
- .getSCMAddresses(tool.getConf());
+ .getSCMAddresses(new
LegacyHadoopConfigurationSource(tool.getConf()));
Review comment:
Wouldn't it be OK to use `OzoneConfiguration.of` instead of `Legacy...` in
this class? Especially since we explicitly create `OzoneGetConf` with an
`OzoneConfiguration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
