umamaheswararao commented on a change in pull request #859: URL: https://github.com/apache/hadoop-ozone/pull/859#discussion_r414392856
########## File path: hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/ha/TestOMFailoverProxyProvider.java ########## @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om.ha; + +import org.junit.Assert; +import org.junit.Test; +import org.junit.Before; + +import java.util.StringJoiner; + +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.ozone.OmUtils; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; + +import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_ADDRESS_KEY; +import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_NODES_KEY; +import static org.apache.hadoop.ozone.OzoneConfigKeys. + OZONE_CLIENT_WAIT_BETWEEN_RETRIES_MILLIS_KEY; +import static org.apache.hadoop.ozone.OzoneConfigKeys. + OZONE_CLIENT_WAIT_BETWEEN_RETRIES_MILLIS_DEFAULT; + +/** + * Tests OMFailoverProxyProvider failover behaviour. + */ +public class TestOMFailoverProxyProvider { + private final static String OM_SERVICE_ID = "om-service-test1"; + private final static String NODE_ID_BASE_STR = "omNode-"; + private final static String DUMMY_NODE_ADDR = "0.0.0.0:8080"; + private OMFailoverProxyProvider provider; + private long waitBetweenRetries; + + @Before + public void init() throws Exception { + OzoneConfiguration config = new OzoneConfiguration(); + long numNodes = 3; Review comment: Hay Attila, Thanks for reviews. It make sense to make it member variable. I remember I extracted it for the purpose and lost that. BTW, that variable should be int, not long. Just updated that too. Take a look. And the pr test failures seems unrelated, I had a quick look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
