elek commented on pull request #925:
URL: https://github.com/apache/hadoop-ozone/pull/925#issuecomment-632215481


   Thanks the patch @hanishakoneru 
   
   I started to test it and deployed it exactly the same way as before and now 
I have three om which are stuck as there are enough voters:
   
   ```
   2020-05-21 16:39:39 INFO  LeaderElection:61 - 
om1@group-D66704EFC61C-LeaderElection139: Election REJECTED; received 0 
response(s) [] and 2 exception(s); om1@group-D66704EFC61C:t139, leader=null, 
voted=om1, raftlog=om1@group-D66704EFC61C-SegmentedRaftLog:OPENED:c-1,f-1,i0, 
conf=-1: [om1:ozone-om-0:9872, om3:ozone-om-2:9862, om2:ozone-om-1:9862], 
old=null
   ```
   
   This is exactly what I needed (clean error instead of starting 3 isolated 
leader).
   
   I also tested with `ozone sh` which doesn't return, but I think it's also 
expected and will be fixed by @bharatviswa504 as part of refactoring of the 
replay structure (I would expected a No leader available exception, or sg. like 
this)
   
   So it works very well. Thank you very much the quick fix.
   
   Will check the code once again tomorrow, after that I am ready to merge it. 
Are you planning to add some unit tests @hanishakoneru? Or is it covered by the 
existing acceptance tests?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to