bharatviswa504 commented on a change in pull request #942:
URL: https://github.com/apache/hadoop-ozone/pull/942#discussion_r428905321
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -654,4 +662,34 @@ private void writeChunkToContainer(ChunkBuffer chunk)
throws IOException {
public void setXceiverClient(XceiverClientSpi xceiverClient) {
this.xceiverClient = xceiverClient;
}
+
+ /**
+ * Handles InterruptedExecution.
+ *
+ * @param ex
+ * @param skipExecutionException is optional, if passed as TRUE, then
+ * handle ExecutionException else skip it.
+ * @throws IOException
+ */
+ private void handleInterruptedException(Exception ex,
+ boolean skipExecutionException)
+ throws IOException {
+ LOG.error("Command execution was interrupted.");
+ if(skipExecutionException) {
Review comment:
Minor NIT: variable name is called skipExecutionException, but when
true, we are handling ExecutionException. I think it should be viceversa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
