bharatviswa504 commented on pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-649695069
>We agreed that this is a dangerous tool. I think it's better to do it explicit rather than implicit in the background. But this is >just my opinion. But if we do the backup of DB, and i don't see any issue. But if we want to be conservative or cautious it might be not to do this. >In fact, with this tool, in some situation, as an administrator of Ozone cluster, if i decided to do some operation with the >rocksdb, i always have approach to modify the rocksdb, i can use the rocksdb/ldb to achieve my goal. What i want to say is >this PR just give me convince, without this tool, cannot prevent me to do this risk things. If admin, wants to do some modifications like this, and ozone is not providing such a tool, and admin still want to build ldb tool and then need to perform these operations which is a long process. So, in this case ozone is not providing such a tool, admin wants to still perform these, not sure in which cases we might need this when code can already handle these things internally. But it looks like as everyone is more interested in getting this tool, even if code can handle by doing minor change, I am okay to move this tool under admin, currently for admin commands, we don't perform any checks is this operation by admin is this missing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
