arp7 commented on a change in pull request #1129:
URL: https://github.com/apache/hadoop-ozone/pull/1129#discussion_r447272528
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2999,32 +3000,15 @@ public TermIndex installSnapshot(String leaderId) {
}
DBCheckpoint omDBcheckpoint = getDBCheckpointFromLeader(leaderId);
- Path newDBlocation = omDBcheckpoint.getCheckpointLocation();
+ Path newDBLocation = omDBcheckpoint.getCheckpointLocation();
LOG.info("Downloaded checkpoint from Leader {}, in to the location {}",
- leaderId, newDBlocation);
+ leaderId, newDBLocation);
- // Check if current ratis log index is smaller than the downloaded
- // checkpoint transaction index. If yes, proceed by stopping the ratis
- // server so that the OM state can be re-initialized. If no, then do not
- // proceed with installSnapshot.
+ OMTransactionInfo omTransactionInfo = getTransactionInfoFromDB(
+ newDBLocation);
- OMTransactionInfo omTransactionInfo = null;
-
- Path dbDir = newDBlocation.getParent();
- if (dbDir == null) {
- LOG.error("Incorrect DB location path {} received from checkpoint.",
- newDBlocation);
- return null;
- }
-
- try {
- omTransactionInfo =
- OzoneManagerRatisUtils.getTransactionInfoFromDownloadedSnapshot(
- configuration, dbDir);
- } catch (Exception ex) {
- LOG.error("Failed during opening downloaded snapshot from " +
- "{} to obtain transaction index", newDBlocation, ex);
+ if (omTransactionInfo == null) {
Review comment:
Let's log an error here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
