[ 
https://issues.apache.org/jira/browse/HDDS-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152669#comment-17152669
 ] 

maobaolong commented on HDDS-3582:
----------------------------------

!image-2020-07-07-19-25-59-658.png!

 

There are another strange style of Ozone. we really need more rule of 
checkstyle to forbid these codes merge into master.

> Update Checkstyle rule
> ----------------------
>
>                 Key: HDDS-3582
>                 URL: https://issues.apache.org/jira/browse/HDDS-3582
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.6.0
>            Reporter: maobaolong
>            Assignee: maobaolong
>            Priority: Major
>         Attachments: image-2020-07-07-19-25-59-658.png, screenshot-1.png, 
> screenshot-2.png, screenshot-3.png, screenshot-4.png
>
>
> Now. the rules of checkstyle is hadoop style, as we all know, hadoop repo 
> started 10 years ago, so some of its rules need to be update.
> For example.
> - 120 length characters of a line make more sense, because most of all have a 
> better monitor than 10 years ago.
> - We need more style rules, such as, behind and after "{" and "}" should have 
> a space. 
> - We should have manage the import into group and order them
> - ModifierOrder is needed
> - Remove the package javadoc rules.
> hope our community getting better and better  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to