rakeshadr commented on a change in pull request #1164:
URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r451327683
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1706,36 +1718,41 @@ public OzoneFileStatus getFileStatus(OmKeyArgs args)
throws IOException {
// Check if the key is a file.
String fileKeyBytes = metadataManager.getOzoneKey(
- volumeName, bucketName, keyName);
- OmKeyInfo fileKeyInfo = metadataManager.getKeyTable().get(fileKeyBytes);
+ volumeName, bucketName, keyName);
+ fileKeyInfo = metadataManager.getKeyTable().get(fileKeyBytes);
+
+ // Check if the key is a directory.
+ if (fileKeyInfo == null) {
+ String dirKey = OzoneFSUtils.addTrailingSlashIfNeeded(keyName);
+ String dirKeyBytes = metadataManager.getOzoneKey(
+ volumeName, bucketName, dirKey);
+ OmKeyInfo dirKeyInfo = metadataManager.getKeyTable().get(dirKeyBytes);
+ if (dirKeyInfo != null) {
+ return new OzoneFileStatus(dirKeyInfo, scmBlockSize, true);
+ }
+ }
+ } finally {
+ metadataManager.getLock().releaseReadLock(BUCKET_LOCK, volumeName,
+ bucketName);
+
+ // if the key is a file then do refresh pipeline info in OM by asking SCM
if (fileKeyInfo != null) {
- if (args.getRefreshPipeline()) {
+ if (refreshPipeline) {
refreshPipeline(fileKeyInfo);
}
Review comment:
Thanks for the review. Good point. For sorting dns, we need to introduce
a new arg **clientAddress** to APIs
[listStatus](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java#L52),
[getFileStatus](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java#L34)
interfaces.
Need to pass a new argument **clientAddress** like
[lookupFile](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java#L45)
API. Can we do interface changes in a separate jira task ?
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -659,15 +660,6 @@ public OmKeyInfo lookupKey(OmKeyArgs args, String
clientAddress)
});
}
}
- // Refresh container pipeline info from SCM
Review comment:
Thanks for the review. Sure, will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
