ChenSammi commented on a change in pull request #1163:
URL: https://github.com/apache/hadoop-ozone/pull/1163#discussion_r452056907
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -260,12 +260,21 @@ public RegisteredCommand register(
if (networkLocation != null) {
datanodeDetails.setNetworkLocation(networkLocation);
}
- nodeStateManager.addNode(datanodeDetails);
- clusterMap.add(datanodeDetails);
- addEntryTodnsToUuidMap(dnsName, datanodeDetails.getUuidString());
- // Updating Node Report, as registration is successful
- processNodeReport(datanodeDetails, nodeReport);
- LOG.info("Registered Data node : {}", datanodeDetails);
+ if (!isNodeRegistered(datanodeDetails)) {
+ clusterMap.add(datanodeDetails);
+ nodeStateManager.addNode(datanodeDetails);
+ // Check that datanode in nodeStateManager has topology parent set
+ DatanodeDetails dn =
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
