adoroszlai commented on a change in pull request #1174:
URL: https://github.com/apache/hadoop-ozone/pull/1174#discussion_r452179572
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/NodeStateMap.java
##########
@@ -88,7 +88,7 @@ public void addNode(DatanodeDetails datanodeDetails,
NodeState nodeState)
throw new NodeAlreadyExistsException("Node UUID: " + id);
}
nodeMap.put(id, new DatanodeInfo(datanodeDetails));
- nodeToContainer.put(id, new HashSet<>());
+ nodeToContainer.put(id, new ConcurrentHashMap().newKeySet());
Review comment:
Nit:
[newKeySet](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#newKeySet--)
is `static`, so creating new `ConcurrentHashMap` instance is unnecessary.
```suggestion
nodeToContainer.put(id, ConcurrentHashMap.newKeySet());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
