adoroszlai opened a new pull request #1204:
URL: https://github.com/apache/hadoop-ozone/pull/1204
## What changes were proposed in this pull request?
1. Fix config key mismatch:
* `raft.client.rpc.watch.request.timeout` vs.
`raft.client.watch.request.timeout`
* `raft.server.notification.no-leader.timeout` vs.
`raft.server.Notification.no-leader.timeout`
2. Use type-safe config for Raft client settings in tests. Get rid of
constants to discourage setting raw config.
3. Fix prefix for `RatisClientConfig.RaftConfig`. `@ConfigGroup` defined in
inner class (`RaftConfig`) does not inherit prefix (`hdds.ratis`) from outer
class (`RatisClientConfig`), so we need to explicitly specify it.
https://issues.apache.org/jira/browse/HDDS-3964
## How was this patch tested?
Ran some affected integration tests locally, verified that custom Ratis
settings were applied:
```
[pool-63-thread-1] INFO server.RaftServerConfigKeys
(ConfUtils.java:logGet(44)) - raft.server.notification.no-leader.timeout =
10000ms (custom)
```
(client property printed by temporary log statement):
```
[Command processor thread] INFO ratis.RatisHelper
(RatisHelper.java:createRaftClientProperties(241)) - ZZZ
raft.client.rpc.watch.request.timeout = 3000ms
```
https://github.com/adoroszlai/hadoop-ozone/runs/873847680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
