umamaheswararao commented on a change in pull request #1215:
URL: https://github.com/apache/hadoop-ozone/pull/1215#discussion_r457671805
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -372,6 +373,34 @@ public boolean rename(Path src, Path dst) throws
IOException {
return result;
}
+ /**
+ * Intercept rename to trash calls from TrashPolicyDefault,
+ * convert them to delete calls instead.
+ */
+ @Deprecated
+ protected void rename(final Path src, final Path dst,
+ final Options.Rename... options) throws IOException {
+ boolean hasMoveToTrash = false;
+ if (options != null) {
+ for (Options.Rename option : options) {
+ if (option == Options.Rename.TO_TRASH) {
+ hasMoveToTrash = true;
+ break;
+ }
+ }
+ }
+ if (!hasMoveToTrash) {
+ // if doesn't have TO_TRASH option, just pass the call to super
+ super.rename(src, dst, options);
+ } else {
+ // intercept when TO_TRASH is found
+ LOG.info("Move to trash is disabled for ofs, deleting instead: {}. "
+ + "Files or directories will NOT be retained in trash. "
+ + "Ignore the following TrashPolicyDefault message, if any.", src);
Review comment:
One last thing: Currently we are straight a way deleting files. Since
users coming from Hadoop shell, there could be assumptions that files may move
to trash if no -skipTrash flag. But we will be deleting instead of trashing
them.
User may realize after looking at this log message, but by this time already
things happened.
There should be a way to shout out this behavior to users. One way is
documenting and any other better way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
