xiaoyuyao commented on a change in pull request #1191:
URL: https://github.com/apache/hadoop-ozone/pull/1191#discussion_r463351164



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerV2Impl.java
##########
@@ -431,15 +464,21 @@ public void scrubPipeline(ReplicationType type, 
ReplicationFactor factor)
    * Schedules a fixed interval job to create pipelines.
    */
   @Override
-  public void startPipelineCreator() {
+  public void startPipelineCreator() throws NotLeaderException {
+    if (!scmhaManager.isLeader()) {

Review comment:
       when scm leader changes, how to ensure the creator and scrubber threads 
are started on the new leader and stopped on the old leader? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to