[ https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated HDDS-4054: --------------------------------- Labels: pull-request-available (was: ) > Remove duplicate judgments in allocateBlockInKey > ------------------------------------------------ > > Key: HDDS-4054 > URL: https://issues.apache.org/jira/browse/HDDS-4054 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Reporter: mingchao zhao > Priority: Major > Labels: pull-request-available > > In HDDS-1666 we have [changed the size of the key > size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439]. > So this size must be >0. > {code:java} > final long size = args.getDataSize() > 0 ? > args.getDataSize() : scmBlockSize; > {code} > We [pass this size when we call > allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480]. > The key must be greater than 0, so the "if (size > 0){}" in > allocateBlockInKey is redundant and should be removed. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org