captainzmc commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r469003376
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java
##########
@@ -101,10 +100,11 @@ void createVolume(String volumeName, VolumeArgs args)
/**
* Set Volume Quota.
* @param volumeName Name of the Volume
- * @param quota Quota to be set for the Volume
+ * @param quotaInBytes The maximum size this volume can be used.
+ * @param quotaInCounts The maximum number of buckets in this volume.
* @throws IOException
*/
- void setVolumeQuota(String volumeName, OzoneQuota quota)
+ void setVolumeQuota(String volumeName, long quotaInBytes, long quotaInCounts)
Review comment:
Thanks @cxorm for the discussion, that's a good question.
The previous feature of Ozone on Set quota is virtual, and this interface
won't have any actual effect. This feature is incomplete, so no one will use it
before.
One way to think about it is that this is the new API, and subsequent
futures will gradually add new interfaces including clrQuota, etc. Users who
want to use full functionality of quota need to update the client.
So I think we can think of this part as a new interface without regard to
backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
