elek commented on pull request #1283: URL: https://github.com/apache/hadoop-ozone/pull/1283#issuecomment-672782797
> test.sh execution also needs to "ignore" errors, otherwise we may not reach rebot. Yes, that's a good question. The scripts of `hadoop-ozone/dev-support/checks/*.sh` have very simple contract: in case of failure a non-zero shell code should be returned. If we would like to keep the same contract for the individual test.sh files we need this `set +/-e` trick. But in this case we couldn't differentiate between errors (in environment / script) and failures (in robot tests). Another option what I started to follow is to make `test.sh` return with 255 only if the test execution failed in the script, and the result of the test can be checked from the robot.xml files. Don't know which one is better. Anyway, let me merge this PR and we can continue to think about theses questions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
